CHORE: Add comprehensive MONEY/SMALLMONEY test suite#485
Merged
gargsaumya merged 8 commits intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated integration test module to validate MONEY/SMALLMONEY handling (and related DECIMAL binding behavior) and removes the older, smaller MONEY/SMALLMONEY tests previously embedded in the large cursor test file.
Changes:
- Added a new
tests/test_020_money_smallmoney.pysuite covering MONEY/SMALLMONEY boundaries, nulls, executemany, and DECIMAL round-trips. - Removed the older MONEY/SMALLMONEY tests from
tests/test_004_cursor.pyto avoid duplication and keep cursor tests focused.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_020_money_smallmoney.py | New comprehensive MONEY/SMALLMONEY/DECIMAL tests covering round-trip and boundary/error scenarios. |
| tests/test_004_cursor.py | Removes prior MONEY/SMALLMONEY-related tests now superseded by the new dedicated module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.8%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.4%
mssql_python.pybind.connection.connection.cpp: 75.8%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.2%🔗 Quick Links
|
bewithgaurav
approved these changes
Apr 21, 2026
jahnvi480
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Added comprehensive MONEY/SMALLMONEY test suite.